fix(lavalink): Refactor search method to use identifier string for track resolution

docker-compose.yml

@@ -11,6 +11,13 @@ services:
       - LAVALINK_SERVER_PASSWORD=${LAVALINK_PASSWORD}
     volumes:
       - ./application.yml:/opt/Lavalink/application.yml:ro,Z
+    # Add healthcheck to verify Lavalink is ready
+    healthcheck:
+      test: ["CMD", "curl", "-f", "http://localhost:2333/v4/info"]
+      interval: 10s
+      timeout: 5s
+      retries: 5
+      start_period: 15s # Give Lavalink time to start up initially
 
   bot:
     build: .
@@ -24,8 +31,10 @@ services:
       - LAVALINK_HOST=lavalink
       - LAVALINK_PORT=2333
       - LAVALINK_PASSWORD=${LAVALINK_PASSWORD}
+    # Update depends_on to wait for healthcheck
     depends_on:
-      - lavalink
+      lavalink:
+        condition: service_healthy
 
 networks:
   bot-network:

src/commands/leave.js

@@ -1,4 +1,4 @@
-const { SlashCommandBuilder } = require('discord.js');
+const { SlashCommandBuilder, MessageFlags } = require('discord.js'); // Import MessageFlags
 const logger = require('../utils/logger');
 
 module.exports = {
@@ -6,11 +6,20 @@ module.exports = {
         .setName('leave')
         .setDescription('Leaves the current voice channel'),
     async execute(interaction, client) { // Added client parameter
-        await interaction.deferReply({ ephemeral: true });
+        // Use flags for ephemeral deferral
+        await interaction.deferReply({ flags: MessageFlags.Ephemeral }); 
 
-        const player = client.manager.get(interaction.guildId);
+        // Get the Shoukaku player manager
+        const musicPlayer = interaction.client.player;
+        if (!musicPlayer) {
+            logger.error('Music player not initialized on client object!');
+            return interaction.editReply('The music player is not ready yet.');
+        }
 
-        // Check if the player exists and the bot is in a voice channel
+        // Get the player for this guild using Shoukaku manager
+        const player = musicPlayer.getPlayer(interaction.guildId);
+
+        // Check if the player exists (Shoukaku player object has voiceChannel property)
         if (!player || !player.voiceChannel) {
             return interaction.editReply('I am not currently in a voice channel!');
         }
@@ -22,11 +31,11 @@ module.exports = {
         // }
 
         try {
-            const channelId = player.voiceChannel;
+            const channelId = player.voiceChannel; // Get channel ID from Shoukaku player
             const channel = client.channels.cache.get(channelId);
             const channelName = channel ? channel.name : `ID: ${channelId}`; // Get channel name if possible
 
-            player.destroy(); // Disconnects, clears queue, and destroys the player instance
+            player.destroy(); // Use Shoukaku player's destroy method
             logger.info(`Player destroyed and left voice channel ${channelName} in guild ${interaction.guild.name} (${interaction.guildId}) by user ${interaction.user.tag}`);
             await interaction.editReply(`Left ${channelName}.`);
 

src/structures/ShoukakuEvents.js

@@ -212,19 +212,22 @@ class MusicPlayer {
         if (!node) throw new Error('No available Lavalink nodes!');
 
         try {
-            // Determine search type
+            // Determine search type and prepare the identifier string
-            let searchOptions = {};
+            let identifier;
             if (query.startsWith('http')) {
                 // Direct URL
-                searchOptions = { query };
+                identifier = query;
             } else {
-                // Search with prefix
+                // Search with prefix (Lavalink handles ytsearch/ytmsearch automatically with the plugin)
-                searchOptions = { query: `ytsearch:${query}` };
+                // identifier = `ytsearch:${query}`; // Prefix might not be needed with the plugin, let Lavalink decide
+                identifier = query; // Pass the raw query for non-URLs
             }
 
-            // Perform the search
+            // Perform the search using the identifier string
-            const result = await node.rest.resolve(searchOptions);
+            const result = await node.rest.resolve(identifier);
             if (!result || result.loadType === 'error' || result.loadType === 'empty') {
+                // Log the identifier for debugging if search fails
+                logger.debug(`Search failed for identifier: ${identifier}`); 
                 throw new Error(result?.exception?.message || 'No results found');
             }